Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins - dependencies and build #81

Open
cjsewell opened this issue May 28, 2023 · 3 comments
Open

Plugins - dependencies and build #81

cjsewell opened this issue May 28, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@cjsewell
Copy link

Feature Request

Currently the docker build only copies and installs the root level package.json and dependencies.

This means if you have built custom plugins under /src/plugins, their dependencies are not installed, and the packages are not build

The build script should search and copy any /src/plugins/*/package.json and install their dependencies.

It should also run any "build" scripts found in plugins package.json

@Eventyret Eventyret added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels May 30, 2023
@Eventyret
Copy link
Member

I do like this though how do you solve a scenario where a user has no plugins runs the tool and later adds the plugins.

@cjsewell
Copy link
Author

I haven't tested it out yet, but I imagine utilizing something like https://stackoverflow.com/a/63142468 to capture all the package.json files.

Assuming workspaces are used, that should work for the dependencies.

As for the build step, I'm not too sure how to pull that off without code.
Maybe submitting a new feature to build.js thay would handle it?

I shall do some experiments....

@Eventyret
Copy link
Member

Did you find out anything else @cjsewell else I will close this issue and you can reopen it if you find out anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants