Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storybook/no-uninstalled-addons false positives on monorepo #127

Open
unional opened this issue Apr 21, 2023 · 3 comments
Open

storybook/no-uninstalled-addons false positives on monorepo #127

unional opened this issue Apr 21, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@unional
Copy link

unional commented Apr 21, 2023

Describe the bug

Getting errors like these in a monorepo:

The @storybook/addon-links is not installed in pats/. Did you forget to install it or is your package.json in a different location?

the pats is the root of the monorepo.
Each package has storybook and addons installed.

Expected behavior
no error

Additional context
I'm not sure if storybook should be hoisted or install only at the top level of monorepo.

Right now, I have each package self-contained and each has their own copy of storybook.

I'm using pnpm.

@yannbf
Copy link
Member

yannbf commented Apr 21, 2023

Hey @unional thanks for opening this issue. Would you be able to either provide a minimal reproduction repo or a PR to fix this issue? This is the rule code: https://github.com/storybookjs/eslint-plugin-storybook/blob/main/lib/rules/no-uninstalled-addons.ts

You could for now disable that rule to unblock you.

@yannbf yannbf added the bug Something isn't working label Apr 21, 2023
@barrymichaeldoyle
Copy link

@yannbf this isn't exactly a fix but it looks like a work around has been implemented here that is better than just blanket ignoring the rule:

#129

@clarkd
Copy link

clarkd commented Nov 11, 2023

We have the same issue here - also using pnpm with a monorepo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants