Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook 7.4 upgrade #70

Closed
wants to merge 2 commits into from
Closed

Storybook 7.4 upgrade #70

wants to merge 2 commits into from

Conversation

paulelliott
Copy link
Member

@paulelliott paulelliott commented Sep 15, 2023

This updates the library to Storybook 7.4 using the automigrations to cover everything except #56 , which I had to resolve manually.

Fixes #56

@paulelliott paulelliott self-assigned this Sep 15, 2023
@socket-security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
New author istanbul-lib-report 3.0.1
New author fd-slicer 1.1.0
New author write-file-atomic 2.4.3
Shell access @aw-web-design/x-default-browser 1.4.126
Shell access esbuild 0.18.20
Shell access jake 10.8.7
Shell access jscodeshift 0.14.0
Shell access update-browserslist-db 1.0.11
Uses eval core-js-pure 3.17.3
Uses eval ejs 3.1.9
Uses eval envinfo 7.10.0
Uses eval uvu 0.5.6

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is eval?

Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Avoid packages that use eval, since this could potentially execute any code.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@paulelliott paulelliott deleted the storybook-7.4-upgrade branch September 15, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Storybook 7.0] Can't resolve '@storybook/api/shortcut'
1 participant