Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need badges without empty space on perimeter #2

Open
HawkeyePierce89 opened this issue Oct 11, 2017 · 5 comments
Open

Need badges without empty space on perimeter #2

HawkeyePierce89 opened this issue Oct 11, 2017 · 5 comments
Assignees

Comments

@HawkeyePierce89
Copy link

image

@steverichey steverichey self-assigned this Oct 11, 2017
@danielpalme
Copy link

You can achieve that by making a simple change in the SVG file(s).
Just change the viewBox to viewBox="10 10 135 40".

@steverichey
Copy link
Owner

I'm hesitant to further edit the SVG files directly, as I'm trying to avoid enforcing an opinion on the files themselves, and also since this would (kind of) violate the branding guidelines. You could almost certainly remove the whitespace with CSS, and when I get around to making some kind of NPM package for this repo, I think I'll include an option to trim whitespace there.

@HawkeyePierce89
Copy link
Author

You could almost certainly remove the whitespace with CSS

O_o
It's dirty workaround

also since this would (kind of) violate the branding guidelines

o_O
You say this seriously?

@ClaudiuCeia
Copy link

There must be clear space surrounding the badge equal to one-quarter the height of the badge.

https://play.google.com/intl/en_us/badges/

It's annoying, sure, but this repo is just offering the converted badges so you don't have to do that yourself as well, I don't think the author should modify them in any way.

@reimar
Copy link

reimar commented Apr 18, 2018

I came here because I was looking for Google Play badges without the margin ;)

I do not think the white space belongs into the files themselves. I think it is something you should read in the style guide and apply it to your layout. But I also understand the approach to not mess with the source files.

If we think there are enough people who need the badges without white space – maybe I can help you by providing a small SVGO plugin / npm script so we can automate output to directories like /img and /img-optimized or sth. like that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants