-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[proposal] Add full screen support #67
Comments
I took a closer look at this, and from what I can see there is no good way of doing this with the current bundled version of electron. The associated chrome version is quite old and doesn't support the standard web API for fullscreen and the webkit API doesn't work properly from my tests. And even if that is based on my mistake, I think it makes more sense to wait for the next bump in the electron version and try working with that. Even then, it could still be that VSCode blocks fullscreen on the Webview panels, if that will be the case in the future I will talk with the devs and see what they are thinking. |
Small update: With the newest version of VSC using the standardized fullscreen api just results in the VSC window to be fullscreen, not the webview itself. So this still doesn't look doable. |
This is a very impressive plugin, and I had a lot of fun with it! However, if the preview has the full-screen feature, it can even be used as a screen saver.
The text was updated successfully, but these errors were encountered: