Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framer Motion Exit looks like not working #16

Open
huuphongnguyen opened this issue Jan 17, 2023 · 3 comments
Open

Framer Motion Exit looks like not working #16

huuphongnguyen opened this issue Jan 17, 2023 · 3 comments

Comments

@huuphongnguyen
Copy link

Hello, I notice that the animation when modal is closed not working. It disappears suddenly when we click on blur to close Modal.
I tried to find some solution, mostly about Framer Motion but I see there are nothing wrong. 馃
Anyone knows how to fix it, I think UX will be better so much if we can fix it.

@steven-tey
Copy link
Owner

cc: @gt-codes who made this PR on Dub to fix this, but there were some caveats to it (it doesn鈥檛 allow for AnimatePresence to animate the Dialog overlay)

@azaek
Copy link

azaek commented Jan 19, 2023

#20 fixed PR

@azaek
Copy link

azaek commented Jan 19, 2023

There are 2 AnimatePresence wrapped in total for screenWidth < 768 which causes it. Just replace the <AnimatePresence> wrap in leaflet.tsx with <>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants