Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: #361 caused a regression of #350 #363

Open
haydenbleasel opened this issue Mar 29, 2024 · 3 comments
Open

bug: #361 caused a regression of #350 #363

haydenbleasel opened this issue Mar 29, 2024 · 3 comments
Assignees

Comments

@haydenbleasel
Copy link
Contributor

haydenbleasel commented Mar 29, 2024

Provide environment information

  System:
    OS: macOS 14.4.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 113.14 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.18.2 - ~/.nvm/versions/node/v18.18.2/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 9.8.1 - ~/.nvm/versions/node/v18.18.2/bin/npm
    pnpm: 8.15.4 - ~/Library/pnpm/pnpm
    bun: 1.0.35 - ~/.bun/bin/bun

Describe the bug

The new drag handle regresses the fix from #350, causing the drag handle not to work in dialogs.

CleanShot 2024-03-29 at 16 55 22@2x

Link to reproduction

TBD

To reproduce

  1. Install Novel
  2. Render Novel in a Radix Dialog
  3. Examine the Drag Handle position

Additional information

No response

@andrewdoro
Copy link
Collaborator

Ok will add a PR to fix this in the new repo
https://github.com/NiclasDev63/tiptap-extension-global-drag-handle

@andrewdoro
Copy link
Collaborator

andrewdoro commented Mar 30, 2024

  • Updated novel demo example to also show a dialog, so we can better track bugs related to this in the future
  • Added PR adding changes from Resolves #234 #350
  • I'll update novel after @NiclasDev63 publishes a new version

@andrewdoro
Copy link
Collaborator

@haydenbleasel published [email protected], should fix this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants