-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] Custom vs Standard service types #624
Comments
Hi @bjsowa |
To give you an example: You define zed_interfaces/reset_odometry type for the |
Ah ok, that's clear. Yes, you are right. They are defined in the same way. |
Tested this suggestion writing the new ROS2 wrapper for ROS2 Eloquent (stereolabs/zed-ros2-wrapper@61ff87e , stereolabs/zed-ros2-wrapper@7dd5970), it's a good suggestion and it will be replicated here with the new version that will be released with the new ZED SDK |
I noticed that you define a custom service type for each service in the
zed_interfaces
package. Why not just use a standard service types like std_srvs/SetBool and std_srvs/Trigger for most of the services?This way, other clients in the ROS network won't need to build the
zed_interfaces
package to, for example, reset the odometry.I know that changing the ROS API can break some applications that use the current one, but I would like you to at least consider this in the future.
The text was updated successfully, but these errors were encountered: