Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node-card): Rendering issues to address #2187

Closed
2 of 5 tasks
simonwinter opened this issue Apr 3, 2024 · 1 comment
Closed
2 of 5 tasks

feat(node-card): Rendering issues to address #2187

simonwinter opened this issue Apr 3, 2024 · 1 comment
Assignees
Labels
module: web Related to web browser clients and interfaces type: bug Addresses a bug type: design Design related issues

Comments

@simonwinter
Copy link
Collaborator

simonwinter commented Apr 3, 2024

Summary

Following on the work of #2174, there are a few issues that have fallen out of this issue:

  • there are new in-flow & on-demand components. They are copy+pasted from the original node-card component. There's much that can be shared, particularly the styles between the components. Let's see what we can rationalise here.
  • The styled-block and styled-inline components are causing some rendering issues (see below). Ideally we'd be able to merge the styles together to resolve these issues.
  • Output overflow not providing scrolling.
  • Tooltips displayed on the on-demand instances are not displaying correctly (i.e. missing bg colour)
  • If a node-card's title is a programming language, ensure that it renders the correct title, capitalisation etc.

CleanShot 2024-04-03 at 16 55 26
Styled block not merging bg colour & padding. Also note the elements are not displayed full width

CleanShot 2024-04-03 at 16 57 44
Inline block not merging bg colour and padding

CleanShot 2024-04-03 at 16 58 55
Dynamically generated classes are not rendering as expected

CleanShot 2024-04-03 at 17 00 07
Missing scrollbar on output with overflow

CleanShot 2024-04-08 at 13 57 27
Tooltips on top of tooltips!

@simonwinter simonwinter added type: bug Addresses a bug module: web Related to web browser clients and interfaces type: design Design related issues labels Apr 3, 2024
@simonwinter simonwinter self-assigned this Apr 3, 2024
@nokome
Copy link
Member

nokome commented May 18, 2024

Closing as mostly done

@nokome nokome closed this as completed May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: web Related to web browser clients and interfaces type: bug Addresses a bug type: design Design related issues
Projects
Status: Done
Development

No branches or pull requests

2 participants