Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(code chunk outputs): add a stencila-ui-node-outputs component and components for common output types e.g. stencila-string, stencila-image-object etc #2145

Open
9 tasks
nokome opened this issue Mar 18, 2024 · 0 comments
Assignees
Labels
needs triaging label added to new issues type: feature Proposes a new feature

Comments

@nokome
Copy link
Member

nokome commented Mar 18, 2024

Summary

Problem

The <stencila-code-chunk> component needs a UI component to display its outputs. This is current unimplemented:

image

Currently, the designs for this are component are minimal and don't show how to display the actual outputs:

image

The outputs of a code chunk can be any Node type but will usually be a primitive type (as listed in "Data values" in #2027), an ImageObject (e.g. a plot) or a Datatable (tabular data with columns having specific types).

The examples/kernels/code-chunk/output-types-r.json and examples/kernels/code-chunk/output-types-python.json have examples of all these output types and illustrate how display of outputs need to be improved.

Each output node needs to be presented separately

This is actually six separate primitive outputs from the one CodeChunk but they are all on the same line:

image

Datatables are not displaying at all because on how they are encoded to DOM HTML

image

Images are shown at full size and not constrained to be within the node card

image

Tasks

  • implement a collapsible <stencila-ui-node-outputs> component (similar to stencila-ui-node-messages and stencila-ui-node-authors)
  • implement components for common node types found in code chunk outputs:
@nokome nokome added type: feature Proposes a new feature needs triaging label added to new issues labels Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triaging label added to new issues type: feature Proposes a new feature
Projects
Status: No status
Development

No branches or pull requests

2 participants