Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): fix secret retrieval and setting #2111

Open
4 tasks
simonwinter opened this issue Mar 7, 2024 · 0 comments
Open
4 tasks

fix(config): fix secret retrieval and setting #2111

simonwinter opened this issue Mar 7, 2024 · 0 comments
Assignees
Labels
module: rust Related to Rust module: web Related to web browser clients and interfaces type: design Design related issues

Comments

@simonwinter
Copy link
Collaborator

Summary

Currently there are a couple of challenges to the saving of the settings panel:

  • GET ~/secrets is fetched on every page load. It should only occur when the secrets config panel is opened
  • Existing secrets should not be able to be modified directly, instead we should clear the existing value before adding a new value
  • OR - users should be able to pasted in a new value which replaces the old value.

This first point will require some loading UI. There are existing designs which applies an overlay on top of the panel, making the elements inaccessible until the request has completed.

Potentially:

  • An alternative approach would be to treat operations on keys a lot more atomically and just fire a POST when a secret is set and a DELETE when the clear button is pressed.

This approach is nicer. It does require some UI, UX and potentially some rust API work:

  • A user clears a field (fire a DELETE - do we prevent any interaction until we get confirmation?)
  • A user enters text into the field & loses focus on the field:
    • Make sure the field is deactivated
    • Send the request
    • Indicate a request is happening on that field
    • Update the UI to show that the field was successfully saved
    • Display the redacted version of the secret that was saved
@simonwinter simonwinter added module: web Related to web browser clients and interfaces module: rust Related to Rust type: design Design related issues labels Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: rust Related to Rust module: web Related to web browser clients and interfaces type: design Design related issues
Projects
Status: No status
Development

No branches or pull requests

2 participants