Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: add tests to @stdlib/utils/compact-adjacency-matrix #1330

Open
3 tasks done
kgryte opened this issue Feb 21, 2024 · 12 comments · May be fixed by #2131
Open
3 tasks done

[RFC]: add tests to @stdlib/utils/compact-adjacency-matrix #1330

kgryte opened this issue Feb 21, 2024 · 12 comments · May be fixed by #2131
Assignees
@Pratik772846
Labels
Accepted RFC feature request which has been accepted. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Tests Pull requests specifically adding tests.

Comments

@kgryte
Copy link
Member

kgryte commented Feb 21, 2024

Description

This RFC requests that tests be added to @stdlib/utils/compact-adjacency-matrix.

Currently, the package lacks sufficient tests. Ideally, this package would achieve 100% test coverage.

What should be tested?

  • All methods
  • Property access
  • All edge cases

For reference, see @stdlib/array/complex64 for a package which exports a custom class and includes extensive unit tests.

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@kgryte kgryte added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! labels Feb 21, 2024
@iItachiUchiha

This comment was marked as outdated.

Sign in to view
@uchiha-vivek
Copy link

Sir i want to work on this issue.I think i can resolve it.

@kgryte
Copy link
Member Author

kgryte commented Feb 23, 2024

Thank you for volunteering to work on this @uchiha-vivek. Feel free to submit a PR implementing the requested tests.

@uchiha-vivek
Copy link

Sir I think I can check this with more edge cases Gonna start work on it.

@kgryte kgryte added Tests Pull requests specifically adding tests. Accepted RFC feature request which has been accepted. JavaScript Issue involves or relates to JavaScript. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. priority: Normal Normal priority concern or feature request. and removed Feature Issue or pull request for adding a new feature. labels Feb 23, 2024
@uchiha-vivek
Copy link

Sir i am having some error in pushing the code .
Meanwhile i have made the changes in the test file by adding few Test cases.
Tasks done
1-Initialising the matrix- all positions of a[i][j] set to 0.
2--Updating the adjacency-matrix NOTE- The updates are continous.
3-Checking whether edge is present between vertices or not // Property of adjacency-matrix

Soon i am going to reslove push issue.
Meanwhile i have pushed it in my local repository
https://github.com/uchiha-vivek/STDLIB/blob/matrix/lib/node_modules/%40stdlib/utils/compact-adjacency-matrix/test/test.js

@kgryte
Copy link
Member Author

kgryte commented Feb 24, 2024

@uchiha-vivek It's quite possible you are not able to push--assuming you have setup your local dev environment--as your code currently has lint errors. You should resolve those before opening a PR.

@soumajit23
Copy link
Contributor

@uchiha-vivek hey can i try working on this if you are having trouble?

@uchiha-vivek
Copy link

@soumajit23 Yes sir you can work on it.

@soumajit23
Copy link
Contributor

@uchiha-vivek thank you so much!
@kgryte can you please assign this to me?

@Pratik772846
Copy link
Contributor

Hey ,@kgryte @Planeshifter @Pranavchiku Can you please assign this to me?

@Pratik772846
Copy link
Contributor

Hey @kgryte @Planeshifter @Pranavchiku Can I work on this issue?

@Pranavchiku
Copy link
Member

Go ahead, feel free to push #1373 forward. Assigned to you.

@Pratik772846 Pratik772846 mentioned this issue Apr 3, 2024
Open
3 tasks
Pratik772846 added a commit to Pratik772846/stdlib that referenced this issue Apr 6, 2024
@Pratik772846
feat: add tests to @stdlib/utils/compact-adjacency-matrix
04807ef 
added tests to @stdlib/utils/compact-adjacency-matrix

Fixes stdlib-js#1330
@Pratik772846 Pratik772846 linked a pull request Apr 6, 2024 that will close this issue
Open
1 task
Pratik772846 added a commit to Pratik772846/stdlib that referenced this issue Apr 7, 2024
@Pratik772846
feat: add tests to @stdlib/utils/compact-adjacency-matrix
6427438 
done some changes related to test messages

Fixes stdlib-js#1330
Pratik772846 added a commit to Pratik772846/stdlib that referenced this issue Apr 7, 2024
@Pratik772846
feat: add tests to @stdlib/utils/compact-adjacency-matrix
66ec4c1 
modified test.from_edges.js

Fixes stdlib-js#1330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pratik772846 Pratik772846

Labels
Accepted RFC feature request which has been accepted. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Tests Pull requests specifically adding tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: add tests to @stdlib/utils/compact-adjacency-matrix Pratik772846/stdlib
6 participants
@kgryte @Pranavchiku @Pratik772846 @soumajit23 @iItachiUchiha @uchiha-vivek