Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: add the Boltzmann distribution #179

Open
4 tasks done
kgryte opened this issue May 2, 2018 · 5 comments · May be fixed by #2108
Open
4 tasks done

RFC: add the Boltzmann distribution #179

kgryte opened this issue May 2, 2018 · 5 comments · May be fixed by #2108
Assignees
@AgPriyanshu18
Labels
Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. RFC Request for comments. Feature requests and proposed changes. Statistics Issue or pull request related to statistical functionality.
Projects
Features

Comments

@kgryte
Copy link
Member

kgryte commented May 2, 2018

Checklist

Please ensure the following tasks are completed before filing an issue.

  • Read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • If this is a general question, searched the FAQ for an existing answer.
  • If this is a feature request, the issue name begins with RFC:.

Description

Description of the issue (or feature request).

This RFC proposes adding the Boltzmann distribution. Similar to other distribution namespaces, adding support for the Boltzmann distribution would entail a family of packages for evaluating the PMF, CDF, mean, median, etc.

Namespace: @stdlib/stats/base/dists/boltzmann
Reference: @stdlib/stats/base/dists/*

Related Issues

Does this issue (or feature request) have any related issues?

No.

Questions

Any questions for reviewers?

No.

Other

Any other information relevant to this issue (or feature request)? This may include screenshots, references, stack traces, sample output, and/or implementation notes.

Reference implementations:
@kgryte kgryte added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Statistics Issue or pull request related to statistical functionality. labels May 2, 2018
@kgryte kgryte added this to Backlog in Features May 18, 2018
@AgPriyanshu18 AgPriyanshu18 mentioned this issue Mar 31, 2024
Closed
6 tasks
@AgPriyanshu18
Copy link
Contributor

@kgryte I would like to work on this issue.

@kgryte
Copy link
Member Author

kgryte commented Mar 31, 2024

@AgPriyanshu18 Thanks for volunteering to work on this. Feel free to submit one or more PRs implementing this functionality. In fact, it may be good to split it over multiple PRs just to simplify review.

@AgPriyanshu18
Copy link
Contributor

@kgryte @Planeshifter, I have stuck on linkting issues with Readme file.
Screenshot from 2024-04-02 09-59-39

The code block on readme file giving issue is
Screenshot from 2024-04-02 10-00-46

PMF Factory method code block is
Screenshot from 2024-04-02 10-01-45

There is no variable named fact in Readme. I would request your help in this issue.

@kgryte
Copy link
Member Author

kgryte commented Apr 2, 2024

But there is a variable named fact in your pmf function, and you haven't declared it. You need to add var fact; to the pmf function you show in your last screenshot.

AgPriyanshu18 added a commit to AgPriyanshu18/stdlib that referenced this issue Apr 2, 2024
@AgPriyanshu18
feat: added stats/base/dists/boltzmann/pmf
1977f37 
Feat added the package stats/base/dists/boltzmann/pmf

Fixes stdlib-js#179
AgPriyanshu18 added a commit to AgPriyanshu18/stdlib that referenced this issue Apr 2, 2024
@AgPriyanshu18
feat: added stats/base/dists/boltzmann/pmf
d2e5df2 
Feat added the package stats/base/dists/boltzmann/pmf

Fixes stdlib-js#179
@AgPriyanshu18 AgPriyanshu18 linked a pull request Apr 2, 2024 that will close this issue
Open
1 task
AgPriyanshu18 added a commit to AgPriyanshu18/stdlib that referenced this issue Apr 2, 2024
@AgPriyanshu18
fix: the data.json in julia
3296ce5 
Added the missing x values in dataset.json file

Fixes stdlib-js#179
@AgPriyanshu18
Copy link
Contributor

@kgryte @Planeshifter Thanks for your help.
I have added the PMF function for Boltzmann distribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AgPriyanshu18 AgPriyanshu18

Labels
Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. RFC Request for comments. Feature requests and proposed changes. Statistics Issue or pull request related to statistical functionality.
Projects
Features
Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: added stats/base/dists/boltzmann/pmf AgPriyanshu18/stdlib
2 participants
@kgryte @AgPriyanshu18