Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using "internal" severely limits the extensibility of the library #101

Open
tobols opened this issue Sep 7, 2021 · 1 comment
Open

Using "internal" severely limits the extensibility of the library #101

tobols opened this issue Sep 7, 2021 · 1 comment

Comments

@tobols
Copy link

tobols commented Sep 7, 2021

Hiding .GetTarget() and .Data in ContextMenuBase with internal unfortunately greatly limits the possibilities of extending the library with custom MenuItems by inheriting from MenuTreeComponent.

Would much prefer to see them public (and possibly other fields as well).

@stavroskasidis
Copy link
Owner

The reasoning behind marking some stuff as internal was to prevent misuse from consumers of the library. I do however see your point about extensibility and I will look into it. From the top of my head, maybe I will add some virtual protected methods that allow you to change the behavior, but I have to look into it more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants