Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚓ Update page-top Quo component to accommodate connected dapps anchor #19867

Closed
shivekkhurana opened this issue May 2, 2024 · 0 comments · Fixed by #19934
Closed

⚓ Update page-top Quo component to accommodate connected dapps anchor #19867

shivekkhurana opened this issue May 2, 2024 · 0 comments · Fixed by #19934
Assignees
Labels
dapp-interactions-team E:Mobile MVP Wallet Connect integration Focusing on integrating the WC functionality and UX flows based on descoped designs feature feature requests
Milestone

Comments

@shivekkhurana
Copy link
Contributor

Feature Issue

User Story

As a developer,
I want to show a dapps link next to account menu on the account details page.

Description

The current Quo component page-nav doesn't allow for adding actions next to the account switcher component. Account switcher is oddly named, it's actually the account menu.

But the new design needs us to show a link to connected dapps next to the account menu:

Current Required
image image
Notice that the account switcher does not have any option for additional actions Design needs the dapp action

Summary: Upgrade the page-nav component and add an option to show an action.

Acceptance Criteria

The page nav component should be update to show an action button.

Notes

There are two approaches to this idea:

  1. Update the wallet-networks type page nav to always show an action or
  2. Create a new type wallet-networks-with-action

I'm inclined to take option 1 unless anyone disagrees. The reason is that the wallet-networks page nav will always have a link to the dapps. I can also make it configurable, ie the icon and the on-press handler can be passed as a prop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment