New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add screen for key-pairs and accounts inside wallet settings #19912
Add screen for key-pairs and accounts inside wallet settings #19912
Conversation
Jenkins BuildsClick to see older builds (75)
|
c8d50a0
to
93bd94f
Compare
93bd94f
to
781bbbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, LGTM :)
781bbbd
to
9f47bb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-review comments 🏄
src/status_im/contexts/settings/wallet/keypairs_and_accounts/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/settings/wallet/keypairs_and_accounts/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/settings/wallet/keypairs_and_accounts/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/settings/wallet/keypairs_and_accounts/view.cljs
Outdated
Show resolved
Hide resolved
01d8e18
to
945d5d8
Compare
src/status_im/contexts/settings/wallet/keypairs_and_accounts/actions/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/settings/wallet/keypairs_and_accounts/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/settings/wallet/keypairs_and_accounts/view.cljs
Outdated
Show resolved
Hide resolved
be6828c
to
24e2f07
Compare
af7668d
to
5c17b23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was curious and reviewed your PR 🙈 LGTM, nice work @seanstrom
src/status_im/contexts/settings/wallet/keypairs_and_accounts/actions/view.cljs
Show resolved
Hide resolved
src/status_im/contexts/settings/wallet/keypairs_and_accounts/view.cljs
Outdated
Show resolved
Hide resolved
src/status_im/contexts/settings/wallet/keypairs_and_accounts/view.cljs
Outdated
Show resolved
Hide resolved
d8491b8
to
6f495bd
Compare
b77ea8a
to
f07cb87
Compare
cc9937f
to
61f7bfb
Compare
88% of end-end tests have passed
Failed tests (4)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestDeepLinksOneDevice:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (46)Click to expandClass TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMerged:
|
@status-im/mobile-qa can you review these E2E results please? 🙏 |
100% of end-end tests have passed
Passed tests (1)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
|
Hi @seanstrom ! |
@VolodLytvynenko thank you 🙌 |
This PR will |
fixes #19915
fixes #19916
Summary
Platforms
Areas that maybe impacted
Functional
Steps to test
wallet-settings
is activatedkeypairs-and-accounts
is activatedBefore and after screenshots comparison
After Changes - Initial UI for displaying key-pairs with accounts, along with opening the action-menu.
Screen.Recording.2024-05-09.at.11.05.36.mov
status: ready