Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selected networks are not shown as preferred if a multichain wallet with preferred networks is scanned on the 'send to' page #19775

Closed
Tracked by #19466
VolodLytvynenko opened this issue Apr 24, 2024 · 1 comment · Fixed by #19899
Closed
Tracked by #19466

Selected networks are not shown as preferred if a multichain wallet with preferred networks is scanned on the 'send to' page #19775

VolodLytvynenko opened this issue Apr 24, 2024 · 1 comment · Fixed by #19899
Assignees
@mmilad75
Labels
E:Mobile Bug MVP E:Mobile Wallet Networks and Routes high-priority

Comments

@VolodLytvynenko
Copy link
Contributor

Follow up for #19668

Steps:

  1. User Asets up a multichain wallet QR with some preferred networks (e.g., 'arb1' only
    image
    )
  2. User B goes to 'send to' page and scans User A's QR
  3. User B Selects an asset for sending
  4. User B enters the available asset amount on the asset sending page.
  5. User B opens the 'edit receiver networks' drawer

Actual result:

All networks are fetched for the receiver as preferable. This happens because, after scanning the QR code in step 2, the address is fetched without an 'arb1' prefix.

android1.mp4

Expected result:

The scanned addresses on the 'send to' page, should be fetched with networks prefixes.

OS:

IOS, Android

Devices:

  • Pixel 7a, Android 13
  • iPhone 11 Pro Max, IOS 17
@VolodLytvynenko
Copy link
Contributor Author

NOTE for QA:

take a look, at the preferable test cases https://ethstatus.testrail.net/index.php?/cases/view/730716 which can be run as sanity after the fixing of this issue

@VolodLytvynenko VolodLytvynenko mentioned this issue Apr 24, 2024
Closed
57 tasks
@mmilad75 mmilad75 self-assigned this Apr 26, 2024
@mmilad75 mmilad75 mentioned this issue May 3, 2024
Merged
mmilad75 added a commit that referenced this issue May 13, 2024
@mmilad75
Selected networks are not shown as preferred if a multichain wallet w…
33da4bf 
…ith preferred networks is scanned on the 'send to' page #19775 (#19899)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmilad75 mmilad75

Labels
E:Mobile Bug MVP E:Mobile Wallet Networks and Routes high-priority
Projects
Do not use - tasks moved to unified Desktop / Mobile Board
Status: Done
Status Desktop/Mobile Board
Status: Done
Milestone
No milestone
2 participants
@VolodLytvynenko @mmilad75