Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Approve transactions #14824

Closed
Tracked by #14598
dlipicar opened this issue May 16, 2024 · 0 comments · Fixed by #15046
Closed
Tracked by #14598

Implement Approve transactions #14824

dlipicar opened this issue May 16, 2024 · 0 comments · Fixed by #15046
Assignees
@dlipicar
Labels
E:Swap Backend M1 swap-team
Milestone
2.30.0 Beta

Comments

@dlipicar
Copy link
Contributor

dlipicar commented May 16, 2024 •
edited

Swaps performed through Paraswap need an Approve tx to be successful before triggering the actual Swap. This needs to be triggered and signed by the client.
@dlipicar dlipicar mentioned this issue May 16, 2024
Open
20 tasks
@dlipicar dlipicar added this to the 2.30.0 Beta milestone May 16, 2024
@dlipicar dlipicar self-assigned this May 17, 2024
dlipicar added a commit that referenced this issue Jun 5, 2024
@dlipicar
feat(@desktop/wallet): initial integration for swap proposal, approve…
56eac34 
… tx and swap tx

Closes #14824
@dlipicar dlipicar mentioned this issue Jun 5, 2024
Merged
dlipicar added a commit that referenced this issue Jun 5, 2024
@dlipicar
feat(@desktop/wallet): initial integration for swap proposal, approve…
a5845ec 
… tx and swap tx

Closes #14824
dlipicar added a commit that referenced this issue Jun 6, 2024
@dlipicar
feat(@desktop/wallet): initial integration for swap proposal, approve…
cb52d78 
… tx and swap tx

Closes #14824
dlipicar added a commit that referenced this issue Jun 6, 2024
@dlipicar
feat(@desktop/wallet): initial integration for swap proposal, approve…
b0f50fa 
… tx and swap tx

Closes #14824
@dlipicar dlipicar mentioned this issue Jun 6, 2024
Merged
Khushboo-dev-cpp pushed a commit that referenced this issue Jun 7, 2024
@dlipicar @Khushboo-dev-cpp
feat(@desktop/wallet): initial integration for swap proposal, approve…
9b21099 
… tx and swap tx

Closes #14824
Khushboo-dev-cpp pushed a commit that referenced this issue Jun 7, 2024
@dlipicar @Khushboo-dev-cpp
feat(@desktop/wallet): initial integration for swap proposal, approve…
bae4ef1 
… tx and swap tx

Closes #14824
dlipicar added a commit that referenced this issue Jun 7, 2024
@dlipicar
feat(@desktop/wallet): initial integration for swap proposal, approve…
e9ef4ec 
… tx and swap tx

Closes #14824
Khushboo-dev-cpp pushed a commit that referenced this issue Jun 7, 2024
@dlipicar @Khushboo-dev-cpp
feat(@desktop/wallet): initial integration for swap proposal, approve…
bc81371 
… tx and swap tx

Closes #14824
dlipicar added a commit that referenced this issue Jun 7, 2024
@dlipicar
feat(@desktop/wallet): initial integration for swap proposal, approve…
b5ca61f 
… tx and swap tx

Closes #14824
dlipicar added a commit that referenced this issue Jun 7, 2024
@dlipicar
feat(@desktop/wallet): initial integration for swap proposal, approve…
77a607a 
… tx and swap tx

Closes #14824
dlipicar added a commit that referenced this issue Jun 10, 2024
@dlipicar
feat(@desktop/wallet): initial integration for swap proposal, approve…
70e6e9b 
… tx and swap tx

Closes #14824
dlipicar added a commit that referenced this issue Jun 10, 2024
@dlipicar
feat(@desktop/wallet): initial integration for swap proposal, approve…
9b552e1 
… tx and swap tx

Closes #14824
anastasiyaig pushed a commit that referenced this issue Jun 11, 2024
@dlipicar @anastasiyaig
feat(@desktop/wallet): initial integration for swap proposal, approve…
60e9414 
… tx and swap tx

Closes #14824
anastasiyaig pushed a commit that referenced this issue Jun 11, 2024
@dlipicar @anastasiyaig
feat(@desktop/wallet): initial integration for swap proposal, approve…
a9503f6 
… tx and swap tx

Closes #14824
Khushboo-dev-cpp pushed a commit that referenced this issue Jun 11, 2024
@dlipicar @Khushboo-dev-cpp
feat(@desktop/wallet): initial integration for swap proposal, approve…
75d755e 
… tx and swap tx

Closes #14824
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlipicar dlipicar

Labels
E:Swap Backend M1 swap-team
Projects
Status Desktop/Mobile Board
Status: Done
Milestone
2.30.0 Beta
Development

Successfully merging a pull request may close this issue.

feat(@desktop/wallet): initial integration for swap proposal, approve… status-im/status-desktop
1 participant
@dlipicar