send LC finality update on event stream on supermajority #5602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When new finality is reached without supermajority sync committee support, trigger another event push on beacon-API and libp2p once the finality gains supermajority support. - ethereum/consensus-specs#3549
|
Should this PR depend on the underlying spec PR being merged? |
|
Shouldn't matter that much, on this one. May lead to a tiny increase in sending gossip that gets ignored (not rejected) by other nimbuses, when sync participation is low while at the same time finality is advancing. |
tersec
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When new finality is reached without supermajority sync committee support, trigger another event push on beacon-API and libp2p once the finality gains supermajority support.
LightClientFinalityUpdateon new supermajority ethereum/consensus-specs#3549