Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated Laguerre fails to approximate signals in hippo_function_approximation.ipynb #101

Open
gbrlfaria opened this issue May 19, 2023 · 3 comments

Comments

@gbrlfaria
Copy link

I've noticed that the translated Laguerre (LagT) HiPPO fails to properly approximate signals in hippo_function_approximation.ipynb (see picture below). The generalized Laguerre formulation in hippo.py also fails. Any clue as to why this is happening?

image

@albertfgu
Copy link
Contributor

Seems like a bug, thanks for reporting. I probably won't have time to look into it for a few weeks. But as mentioned in HTTYH, I don't recommend using LagT anyways.

@sdafkldkfaj
Copy link

hi @gbrlfaria have you figured out what might be causing this problem?

@sdafkldkfaj
Copy link

hi @albertfgu would it be possible that there is a sign flip or missing scaling factor somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants