nspawn wrongly detected as OCI

[clementd64]

Bug Report

Current Behavior

While running in a systemd-nspawn, the container module report OCI

Expected Behavior

systemd-nspawn or nspawn to be reported

Additional context/Screenshots

When /run/host/container-manager exist, OCI is hardcoded

starship/src/modules/container.rs

Lines 24 to 27 in cce9d33

	if context_path(context, "/run/host/container-manager").exists() {
	// OCI
	return Some("OCI".into());
	}

But systemd-nspawn also create this file with systemd-nspawn inside https://github.com/systemd/systemd/blob/8f0de5c433929782f7582a743d3b3d88bea9696d/src/nspawn/nspawn.c#L4148-L4149
This check is made early, bypassing the /run/systemd/container one.

Possible Solution

Check the file content.

[brewedBorrows]

hey @andytom can I work on this?

[andytom]

hey @andytom can I work on this?

Yep sure please feel free to pick this up.

[brewedBorrows]

@andytom Hey, I fixed the issue, but can you have a look at the approach brewedBorrows/starship-fork1@master...brewedBorrows:starship-fork1:nspawn_OCI_#5937 . If you approve I will raise PR and add tests if needed.

[andytom]

Hey @brewedBorrows, the approach looks fine there are some things I would like to suggest but if you open a PR we can discuss them there.

[brewedBorrows]

#5943
Here's the PR @andytom