Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bold fg:none isn't bold #5927

Open
7v0lk0v opened this issue Apr 13, 2024 · 1 comment
Open

bold fg:none isn't bold #5927

7v0lk0v opened this issue Apr 13, 2024 · 1 comment
Labels
💥 breaking-change Something which could break existing usage of starship ✨ enhancement A new feature implementation.

Comments

@7v0lk0v
Copy link

7v0lk0v commented Apr 13, 2024

Current Behavior

As per title. Color of fg shouldn't affect other attributes. Example below is the style for directory.

Expected Behavior

Text should be bold using the default term color.

Additional context/Screenshots

Instead of bold text it's just regular.

Possible Solution

Environment

  • Starship version: 1.18.2
  • bash version: GNU bash, version 5.2.26(1)-release (x86_64-pc-linux-gnu)
    Copyright (C) 2022 Free Software Foundation, Inc.
    License GPLv3+: GNU GPL version 3 or later http://gnu.org/licenses/gpl.html

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

  • Operating system: Artix Linux Rolling Release
  • Terminal emulator: tmux 3.4
  • Git Commit Hash:
  • Branch/Tag: v1.18.2
  • Rust Version: rustc 1.77.1 (7cf61ebde 2024-03-27) (Arch Linux rust 1:1.77.1-1)
  • Rust channel: release
  • Build Time: 2024-04-01 19:57:30 +00:00

Relevant Shell Configuration

if in_path starship; then
	eval "$(starship init bash)"
fi

Starship Configuration

## FIRST LINE/ROW: Info & Status
# First param ─┌
format = """
$username\
$hostname\
$directory\
$git_branch\
$git_state\
$git_status\
$time $cmd_duration\
\n\
$character"""

[username]
format = " [$user]($style)@"
show_always = true
style_root = "bold red"
style_user = "bold red"
disabled = true

# Second param
[hostname]
disabled = false
format = "[$hostname]($style) in "
ssh_only = true
style = "bold dimmed red"
trim_at = "-"

# Third param
[directory]
style = "bold fg:none"
truncate_to_repo = true
truncation_length = 0
truncation_symbol = "repo:"

# Fourth param
[sudo]
disabled = false

# Before all the version info (python, nodejs, php, etc.)
[git_status]
ahead = "⇡${count}"
behind = "⇣${count}"
deleted = "x"
diverged = "⇕⇡${ahead_count}⇣${behind_count}"
style = "white"

# Last param in the first line/row
[cmd_duration]
disabled = false
format = "[$duration]($style)"
style = "default"
min_time = 1


## SECOND LINE/ROW: Prompt
# Somethere at the beginning
[battery]
charging_symbol = ""
disabled = true
discharging_symbol = ""
full_symbol = ""

[[battery.display]]  # "bold red" style when capacity is between 0% and 10%
disabled = false
style = "bold red"
threshold = 15

[[battery.display]]  # "bold yellow" style when capacity is between 10% and 30%
disabled = true
style = "bold yellow"
threshold = 50

[[battery.display]]  # "bold green" style when capacity is between 10% and 30%
disabled = true
style = "bold green"
threshold = 80

# Prompt: optional param 1
[time]
disabled = false
#format = " 🕙$time($style)\n"
format = "$time($style)"
style = "bright-white"
time_format = "%T"

# Prompt: param 2
[character]
#error_symbol = " [×](bold red)"
#success_symbol = " [╰─λ](bold red)"
#success_symbol = " [$](bold red)"

# SYMBOLS
[status]
disabled = true
format = '[\[$symbol$status_common_meaning$status_signal_name$status_maybe_int\]]($style)'
map_symbol = true
pipestatus = true
symbol = "🔴"

[aws]
symbol = ""

[conda]
symbol = ""

[dart]
symbol = ""

[docker_context]
symbol = ""

[elixir]
symbol = ""

[elm]
symbol = ""

[git_branch]
symbol = ""
style = "default"
format = "[$symbol$branch(:$remote_branch)]($style) "

[golang]
symbol = ""

[hg_branch]
symbol = ""

[java]
symbol = ""

[julia]
symbol = ""

[nim]
symbol = ""

[nix_shell]
symbol = ""

[nodejs]
symbol = ""

[package]
symbol = ""

[perl]
symbol = ""

[php]
symbol = ""

[python]
symbol = ""

[ruby]
symbol = ""

[rust]
symbol = ""

[swift]
symbol = ""
@7v0lk0v 7v0lk0v added the 🐛 bug Something isn't working as expected. label Apr 13, 2024
@davidkna
Copy link
Member

Per the docs none or fg:none are supposed to work this way, so if we decide to change this, we may need to treat this a breaking change.

@davidkna davidkna added ✨ enhancement A new feature implementation. 💥 breaking-change Something which could break existing usage of starship and removed 🐛 bug Something isn't working as expected. labels Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥 breaking-change Something which could break existing usage of starship ✨ enhancement A new feature implementation.
Projects
None yet
Development

No branches or pull requests

2 participants