Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vim mode symbols for bash #5681

Open
smashaal opened this issue Jan 3, 2024 · 2 comments · May be fixed by #5758
Open

vim mode symbols for bash #5681

smashaal opened this issue Jan 3, 2024 · 2 comments · May be fixed by #5758
Labels
✨ enhancement A new feature implementation.

Comments

@smashaal
Copy link

smashaal commented Jan 3, 2024

Feature Request

Is your feature request related to a problem? Please describe.

vim-mode is available in bash as of bash 4.3 (current bash widely available (e.g. by brew install bash) is 5.2 as of Jan 2024). However, starship does not support vimcmd_symbol configuration for bash as it does for fish shell, for example

Describe the solution you'd like

if the user is using a new enough bash that supports vim mode, starship should show vim symbol mode as usual

Describe alternatives you've considered

pretty sure there's no simply way around this 🤷
@smashaal smashaal added the ✨ enhancement A new feature implementation. label Jan 3, 2024
@stumash
Copy link

stumash commented Jan 24, 2024

I'm just having trouble understanding where the Properties.keymap value is set so that I can have it get set in bash also. Then it's just a matter of updating the match (shell, keymap) { ... } cases to handle the Bash, "vicmd" case as well

@stumash
Copy link

stumash commented Jan 31, 2024

Just for bookkeeping: the fix will have to be in starship.bash where the --keymap flag needs to be set using environment variables that newer bash uses to manage vim-like editing mode. See starship.fish to see what the code will roughly need to look like

@stumash stumash linked a pull request Feb 6, 2024 that will close this issue
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ enhancement A new feature implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

line editing mode for bash stumash/starship
2 participants
@stumash @smashaal