Extra credentials in connection

[mahic]

Describe the feature

dbt-trino doesn't support extra_credential while trino-python-client supports it

Describe alternatives you've considered

Use http_headers to supply X-Trino-Extra-Credential

This doesn't work with multiple extra credentials because http_headers is a dict.

Who will benefit?

Users who usually use extra credentials

Are you willing to submit PR?

• Yes I am willing to submit a PR!

[damian3031]

Hi @mahic, I believe there are no contraindications for adding it to dbt-trino. You are more than welcome to contribute! Please let me know if you need any assistance

[mahic]

@damian3031 ref comment seems like the workaround might be the following:

http_headers: {X-Trino-Extra-Credential: "cred1=xxx,cred2=yyyy,cred3=zzzz"}

What threw us off was that when we tested this with DBeaver, the client sent 2 headers. This is because trino-client (and Trino JDBC Driver) seems to prefer to send multiple headers over the short-form

However, since trino-python-client supports the extra_credential parameter explicitly (and so does the trino-client/Trino JDBC driver), dbt-trino should match this IMO, do you agree?

[hovaesco]

However, since trino-python-client supports the extra_credential parameter explicitly (and so does the trino-client/Trino JDBC driver), dbt-trino should match this IMO, do you agree?

Yes, it should match, feel free to post a PR with the implementation, we're ready to help.