-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standard does not forward --server to rubocop #462
Comments
Howdy. I spent ten minutes looking into this (I'd never heard of the This should be achievable, but I don't think I'm going to make the time to do this myself. Some breadcrumbs if you or someone else wants to take a stab at a PR:
I believe a PR could implement this behavior of either forking or forwarding to RuboCop's server commands from a new Standard set of commands. Because the server is doing stuff, there's a chance we'd need to fork or patch whatever the RuboCop server is invoking, in turn, though, so it's not really clear it'd work. |
Thanks for that background @searls, very appreciated. In the meantime, an interim way to go would be using Rubocop directly with Standard's set of cops. |
Issue
When running standardrb on the CLI, I expect that any args not recognized by standard will be forwarded to the rubocop invocation. This does not seem to happen with
--server
.Expectation
Subsequent invocations of standardrb should run much faster when the rubocop server has been launched after the first invocation.
Example
Full file path intentionally omitted above.
As you can see, there is no appreciable speedup seen when passing the
--server
option.In addition, the rubocop server has not been launched.
The text was updated successfully, but these errors were encountered: