Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split large generated files #36

Open
robinkrahl opened this issue Feb 18, 2024 · 1 comment
Open

Split large generated files #36

robinkrahl opened this issue Feb 18, 2024 · 1 comment

Comments

@robinkrahl
Copy link
Contributor

The generated files in fitparser/src/profile are so big that GitHub refuses to display them to unauthenticated users and that it is hard to read diffs from SDK updates. Have you considered splitting them into sub-modules per message or field type?

@stadelmanma
Copy link
Owner

I hadn’t really considered it. I’ve only ever given those diffs a quick scroll through on the command line and moved on unless something looked fishy. I don’t think I’d be opposed to splitting them up as long as there’s not any undesirable side effects like greatly increasing build times.

I can’t imagine runtime performance would change at all, nor would the size of the code on disk appreciably increase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants