Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for @testing-library/react with Select #118

Open
ian5484 opened this issue Dec 17, 2019 · 2 comments
Open

support for @testing-library/react with Select #118

ian5484 opened this issue Dec 17, 2019 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@ian5484
Copy link

ian5484 commented Dec 17, 2019

I am having trouble triggering the onChange or setValues when dispatching a change event when using a Select. Would you be able to provide an example for this? I have a suspicion this might be a bug.

Here is what I have been trying:

fireEvent.change(container.querySelector('input[name="phoneNumber"]'), { target: { value: "18005551234" } });

This works for basic fields like TextField but I think some of the onChange shims might be interfering the dispatched change event for Select.

The values prop in the Formik render scope never updates if the input is from the Select, however immediately updates if it's a TextField.

@cliedeman cliedeman added the help wanted Extra attention is needed label Jan 19, 2020
@cliedeman
Copy link
Collaborator

@testing-library/react has been integrated into the project but not all the components have the better tests yet.

@pskfry
Copy link

pskfry commented Apr 1, 2020

in tests i typically mock all material ui components. do you have a reason for not doing so here? it is much easier just to replace all material ui inputs with native html tags. i think you can trust material-ui's internal unit tests to verify that a select input works the way it's supposed to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants