Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove signer log when DKG doesn't succeed #4757

Closed
hstove opened this issue May 7, 2024 · 2 comments
Closed

Remove signer log when DKG doesn't succeed #4757

hstove opened this issue May 7, 2024 · 2 comments
Labels
3.0 3.1 Size: 🐨 S (< 1 week)

Comments

@hstove
Copy link
Contributor

hstove commented May 7, 2024 •
edited

When a new 2.5 reward cycle starts and the aggregate key isn't set, the signer has this log every few seconds:

Signer #N: Could not lookup current miner while in active reward cycle

I thought we'd removed this log during 2.5, but looks like we haven't.

Relates to:
@diwakergupta diwakergupta mentioned this issue May 8, 2024
Closed
@wileyj
Copy link
Contributor

wileyj commented May 8, 2024

#4760

@hstove is it feasible to have a PR addressing this for next week?

@hstove hstove mentioned this issue May 8, 2024
Closed
@hstove hstove linked a pull request May 8, 2024 that will close this issue
fix: dont log "couldn't connect to miner" in 2.5 #4768
Closed
@diwakergupta
Copy link
Member

Fixed by #4768

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.0 3.1 Size: 🐨 S (< 1 week)
Projects
Stacks Core Eng
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: dont log "couldn't connect to miner" in 2.5 stacks-network/stacks-core
4 participants
@diwakergupta @saralab @hstove @wileyj