There's also a similar, related, issue: #107 (for embed of Peertube)

This feature request was discussed on SN, Item #18804.

So unfortunately because of the way Rumbles revenue sharing works pasting the link in the top url and getting an embed is not possible like is done in Item #18804 but you can copy the embed link at the bottom of the video

https://rumble.com/embed/v17j3tt/?pub=3fid3f vs https://rumble.com/v1a59rb-rumble-basics-how-to-embed-your-video.html the first being what can be embedded.

I was able to create a branch that tests embeds for rumble and I would like to eventually embed all the sites but lets start with the POC first in #981

@huumn @benalleng I've looked into this area myself today and Ben is right - you cannot use the Rumble URL to embed a video - only the dedicated Embed url will work. Rumble is different to YouTube because it doesn't use the video id in the url so you don't have anything to work with.

There's a potential hack where you could get the HTML content from the Rumble html page and then parse that to get the video id (it is in there) but you would need to make http requests from the backend (due to CORS policy blocking requests from the browser) and that would be too expensive as it would need to happen when anyone just looks at a post.

However, there's still some value in offering embed link functionality on its own - was there a reason this wasn't completed that I don't know about?

@benalleng was struggling to add the hack approach in #981 and I think decided to work on something else.

I think I can just add the basic embed link functionality in. I would reuse some of Ben's logic and tidy a few places up. Let me know if you want me to go ahead?

It had to do with this need for a reverse proxy here #981 (comment). We had come to the conclusion that the embed link doesn't really have a ton of value if no-one ever uses it. Since everyone is conditioned by youtube's the link you see is the link you need, I tried adding the ability to paste the top url but I have no idea where to start on building a reverse-proxy server / worked for sn

I think you can totally try to get it the rest of the way! This PR does include working support for peertube links and its forks like bitcoin.tv. If nothing else you can just split that code off and close #107

I think I can just add the basic embed link functionality in.

As far as I remember the regular embed links actuallly work as-is, but feel free to tidy the code up. Definitely one of my weak-points lol

Thanks for the info. I'll try and take a look tomorrow.