Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to remove node_modules via --nodemodules flag #1

Open
ssx opened this issue Sep 22, 2019 · 2 comments
Open

Add option to remove node_modules via --nodemodules flag #1

ssx opened this issue Sep 22, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@ssx
Copy link
Owner

ssx commented Sep 22, 2019

No description provided.

@ssx ssx self-assigned this Sep 22, 2019
@ssx ssx added the enhancement New feature or request label Sep 22, 2019
@b1rdex
Copy link

b1rdex commented Apr 30, 2020

This shouldn't be done. I'm sure people have the JavaScript environment when they have node_modules, so no need to clear it with PHP.
There is https://classic.yarnpkg.com/en/docs/cli/autoclean/ that does it the best already.

@ssx
Copy link
Owner Author

ssx commented May 15, 2020

This shouldn't be done. I'm sure people have the JavaScript environment when they have node_modules, so no need to clear it with PHP.

There is https://classic.yarnpkg.com/en/docs/cli/autoclean/ that does it the best already.

It’ll be purely optional.

Users that use JS build tooling won’t need the directory after it’s built so in that instance it’s fine to delete.

I was aware of autoclean but from what I’ve seen it’s very rarely present in repos for it to be useful. It’d be better for users to use that themselves than being used by skrub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants