Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH Client Put File Throws No connection or client supplied. #84

Open
cpmoore opened this issue Mar 26, 2024 · 2 comments
Open

SSH Client Put File Throws No connection or client supplied. #84

cpmoore opened this issue Mar 26, 2024 · 2 comments

Comments

@cpmoore
Copy link

cpmoore commented Mar 26, 2024

Hi ya,
The ssh client command throws an IllegalArgumentException due to the following line

super(builder.connection.orElse(builder.clientSupplier.orElseThrow(() -> new IllegalArgumentException("No connection or client supplied.")).apply(0).getConnection()));

The orElse is evaluated before returning the connection, which in turn gets evaluated to the orElseThrow since clientSupplier is empty
It needs to be converted to an orElseGet like

super(builder.connection.orElseGet(() -> builder.clientSupplier.orElseThrow(() -> new IllegalArgumentException("No connection or client supplied.")).apply(0).getConnection()));

@ludup
Copy link
Contributor

ludup commented Apr 3, 2024

Thanks for the information. We have confirmed this and applied the change to the 3.1.2-SNAPSHOT, which should be published to maven shortly and committed to the develop_3.1.x branch.

@amcarthur
Copy link

amcarthur commented May 16, 2024

Any idea when 3.1.2 will be released? Either I'm too dumb to properly add the sonatype snapshot repo to my gradle config, or my company disabled snapshots somehow

Edit: never mind, our maven repo mirror is just slow. Should sync your snapshots eventually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants