Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mix entropy with hmac instead of xor #252

Open
alokmenghrajani opened this issue Aug 25, 2020 · 2 comments
Open

Mix entropy with hmac instead of xor #252

alokmenghrajani opened this issue Aug 25, 2020 · 2 comments

Comments

@alokmenghrajani
Copy link
Contributor

Xor was simpler to implement but hmac would be cleaner.
@ivmaykov
Copy link
Contributor

ivmaykov commented Oct 5, 2023

I'm probably being too pedantic here, but we should probably use a proper KDF rather than hmac. Some options would be: HKDF, PBKDF, or Argon2.

@alokmenghrajani
Copy link
Contributor Author

Agree. It's probably overkill (even a simple hash of the two concatenated buffers should be fine). It's computationally cheap to use a KDF and buys some peace of mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alokmenghrajani @ivmaykov