Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

Keywhiz has inconsistencies in filename enforcement #170

Open
sqshh opened this issue Jan 29, 2016 · 1 comment
Open

Keywhiz has inconsistencies in filename enforcement #170

sqshh opened this issue Jan 29, 2016 · 1 comment
Labels

Comments

@sqshh
Copy link

sqshh commented Jan 29, 2016

As evidenced by this output:

keywhiz.cli describe secret --name shh.2016-01-26T23:49:27Z.key
Exception in thread "main" java.lang.IllegalArgumentException: Invalid name, must match ^[a-zA-Z_0-9\-.]+$
    at keywhiz.cli.commands.DescribeAction.run(DescribeAction.java:58)
    at keywhiz.cli.CommandExecutor.executeCommand(CommandExecutor.java:141)
    at keywhiz.cli.CliMain.main(CliMain.java:68)

This secret was added via the automation API and otherwise is served and is displayed correctly.

@sqshh sqshh added the bug label Jan 29, 2016
@alokmenghrajani
Copy link
Contributor

We should remove the check in the cli and enforce (if we wish to) on the server side. Given that the secrets end up being accessed via a file system API, limiting the name to some subset of characters we know work across platforms is probably going to be a good idea.

@worldwise001 worldwise001 self-assigned this Jul 5, 2016
@worldwise001 worldwise001 removed their assignment Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants