-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to require verify scripts during deployment #799
Comments
Yeah, optionally requiring verify scripts makes a ton of sense. |
Given that we would want to support the same feature with the same name in the sqitch deploy --strict-verify
sqitch verify --strict But its semantics will vary from the existing Sketch implementation:
|
Yes,
Should it be a separate config variable A separate config variable may be misleading:
Or do we just say that |
It would be great if
sqitch deploy
had an option to require a verify script for each deploy script. Right now, missing verify scripts are only logged without failing the deployment when runningsqitch deploy --verify
, for example:I recently had this situation when a team mate accidentally moved some of the verify scripts. The test runner did not fail but luckily I spotted the moved files during code review. A failing test run would've been better in catching this right away.
Of course I can add a step to the test runner to manually check the files. Something like:
But I think it's useful if Sqitch can support this out of the box. Also because this script above makes assumptions about the directory layout which is quite flexible in Sqitch.
I'm thinking about a new option
--require-verify
:Maybe even imply
--verify
when deploying with--require-verify
so that it behaves as a stronger variant of--verify
. I think the option name fits nicely with the existing--no-verify
to allow different verification levels, i.e.--no-verify
<--verify
<--require-verify
.The text was updated successfully, but these errors were encountered: