Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove QHeaderView patch #332

Closed
dalthviz opened this issue Apr 5, 2022 · 2 comments · Fixed by #334
Closed

Remove QHeaderView patch #332

dalthviz opened this issue Apr 5, 2022 · 2 comments · Fixed by #334
Assignees
@dalthviz
Labels
type:Task
Milestone
v2.1.0

Comments

@dalthviz
Copy link
Member

dalthviz commented Apr 5, 2022

Checking a little bit I think the current logic for the QHeaderView patch was done in order to give support to removed methods from PyQt4/PySide/Qt4 (#64 #65) and rigth now the test for the patch is being skipped in a good amount of testing setups since segfaults with Qt 5.15+ Qt6 and also with Python 3.7+ on MacOS

Taking this into account, maybe we should consider removing this patch logic? What do you think @ccordoba12 @CAM-Gerlach ?
@ccordoba12
Copy link
Member

I agree with that.

@dalthviz dalthviz added this to the v2.1.0 milestone Apr 6, 2022
@dalthviz dalthviz self-assigned this Apr 6, 2022
@CAM-Gerlach
Copy link
Member

I agree as well; #26 offered a fairly compelling rationale to avoid these sorts of matches.

@dalthviz dalthviz mentioned this issue Apr 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dalthviz dalthviz

Labels
type:Task
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging a pull request may close this issue.

PR: Remove QHeaderView patch related files dalthviz/qtpy
3 participants
@ccordoba12 @dalthviz @CAM-Gerlach