Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"setup.py install" has been deprecated in setuptools #200

Open
kumattau opened this issue Dec 24, 2021 · 2 comments
Open

"setup.py install" has been deprecated in setuptools #200

kumattau opened this issue Dec 24, 2021 · 2 comments

Comments

@kumattau
Copy link
Contributor

from: #199 (comment)

"setup.py install" has been deprecated in setuptools 58.3.0 (05 Nov 2021).

pypa/setuptools@fc5c308#diff-d9f946e5d366d670898f9cfaa80a8f892853686b6533a07c40ba9e9d4ee0e862

but, qtawesome imports setuptools.command.install in setup.py

from setuptools.command.install import install

Maybe, we need to consider about "setup.py install" and "setuptools.command.install".

@dalthviz dalthviz added this to the v1.2.0 milestone Dec 24, 2021
@dalthviz
Copy link
Member

I think the work done on QtPy could be useful as guide here: spyder-ide/qtpy#272

@dalthviz
Copy link
Member

Seems like there a deprecation warning appeared when building the package distribution (probably since I updated setuptools to release v1.2.2 or maybe it was happening before but I didn't see it):

SetuptoolsDeprecationWarning:     Installing 'qtawesome.fonts' as data is deprecated, please list it in `packages`.
    !!


    ############################
    # Package would be ignored #
    ############################
    Python recognizes 'qtawesome.fonts' as an importable package,
    but it is not listed in the `packages` configuration of setuptools.

    'qtawesome.fonts' has been automatically added to the distribution only
    because it may contain data files, but this behavior is likely to change
    in future versions of setuptools (and therefore is considered deprecated).

    Please make sure that 'qtawesome.fonts' is included as a package by using
    the `packages` configuration field or the proper discovery methods
    (for example by using `find_namespace_packages(...)`/`find_namespace:`
    instead of `find_packages(...)`/`find:`).

    You can read more about "package discovery" and "data files" on setuptools
    documentation page.

More info about that at pypa/setuptools#3340

@dalthviz dalthviz modified the milestones: v1.3.0, v1.4.0 Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants