Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Remember-Me for OAuth2 login #15078

Open
gotson opened this issue May 16, 2024 · 0 comments
Open

Support Remember-Me for OAuth2 login #15078

gotson opened this issue May 16, 2024 · 0 comments
Labels
status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement

Comments

@gotson
Copy link

gotson commented May 16, 2024

When OAuth2 login is enabled, remember-me parameter (ie when it's not set to always remember) will not be honored, because the original request (to /oauth2/authorization/<provider>) is different from the actual request coming back from the OAuth2 provider (to /login/oauth2/code/<provider>), and that second request does not have the remember-me parameter set.

It would be good if this could be supported, ie when calling /oauth2/authorization/<provider>?remember-me=true, the response would set the remember-me cookie.

Expected Behavior

Remember-me cookie is set on OAuth2 login response

Current Behavior

Remember-me cookie is not set on OAuth2 login response

Context

My application offers optional OAuth2 login, along with traditional username/password login. There is a checkbox for remember-me, but this does not apply to OAuth2 login currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant