Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SET command instead of SETEX #2897

Open
ehsanalemzadeh opened this issue Apr 21, 2024 · 2 comments
Open

Use SET command instead of SETEX #2897

ehsanalemzadeh opened this issue Apr 21, 2024 · 2 comments
Labels
status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement

Comments

@ehsanalemzadeh
Copy link

ehsanalemzadeh commented Apr 21, 2024 •
edited

In DefaultValueOperations, the set method with timeout argument calls the setEx command internally. However, SETEX command was deprecated in version 2.6.12 of Redis. According to Redis documentation, it is recommended to replace SETEX with SET using the EX argument. Redis documentation
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 21, 2024
@mp911de
Copy link
Member

mp911de commented Apr 23, 2024

Good catch. Do you want to submit a pull request?

@mp911de mp911de added status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 23, 2024
@ehsanalemzadeh
Copy link
Author

Sure. I will do it soon.

ehsanalemzadeh added a commit to ehsanalemzadeh/spring-data-redis that referenced this issue Apr 24, 2024
@ehsanalemzadeh
Polishing.
e24b2a4 
Replace usage of deprecated commands setEx, pSetEx and setNX in DefaultValueOperations by set command with additional SetOption arguments

Closes #spring-projects#2897
@ehsanalemzadeh ehsanalemzadeh mentioned this issue Apr 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mp911de @spring-projects-issues @ehsanalemzadeh