-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undo Rollout (Manifest) Stage doesn't work with gRPC handler #6947
Comments
JoelCi
changed the title
Undo Rollout (Manifest) Configuration hasn't work with gRPC handler
Undo Rollout (Manifest) Configuration hasn't worked with gRPC handler
Apr 17, 2024
JoelCi
changed the title
Undo Rollout (Manifest) Configuration hasn't worked with gRPC handler
Undo Rollout (Manifest) Stage doesn't work with gRPC handler
Apr 17, 2024
This issue hasn't been updated in 45 days, so we are tagging it as 'stale'. If you want to remove this label, comment:
|
@spinnakerbot remove-label stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is an odd error trying to do automatic rollback of a helm deployment that uses gRPC handler for probes.
The problem is that spinnaker doesn't recognize "grpc" as a method for probes (even though it didn't happen during the deployment ).
And the error that it is showing is:
Failed to undo rollout deployment/my-app from app-namespace: error: failed restoring revision 3: Deployment.apps "my-app" is invalid: [spec.template.spec.containers[0].livenessProbe: Required value: must specify a handler type, spec.template.spec.containers[0].readinessProbe: Required value: must specify a handler type, spec.template.spec.containers[0].startupProbe: Required value: must specify a handler type]
NOTE: the rollback step is well configured, same config was tested with another app that uses "httpGet" instead of "grpc" for the probes, and the rollback step didn't fail.
The text was updated successfully, but these errors were encountered: