-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LaTeX/ImageConverter: Regression with data:
URIs
#12331
Comments
I've been investigating this, after recently modifying some image-download code -- I was wondering if that could be related. It doesn't seem to be, but I'll report some findings from along the way: An important part of 0a76199 seems to be: @@ -117,7 +117,7 @@ class DataURIExtractor(BaseImageConverter):
default_priority = 150
def match(self, node: nodes.image) -> bool:
- if self.app.builder.supported_remote_images == []:
+ if not self.app.builder.supported_remote_images:
return False
if self.app.builder.supported_data_uri_images is True:
return False ...in particular because Before 0a76199, the |
Describe the bug
Images with
data:
URIs are not converted correctly in LaTeX output.This is the error when running LaTeX:
How to Reproduce
Try to build the LaTeX/PDF from https://github.com/mgeier/rsvgconverter-bug, after disabling the
rsvg_converter_bin
setting inconf.py
(https://github.com/mgeier/rsvgconverter-bug/blob/8e107a6c7fca594a30c540117007716e967ee83e/conf.py#L5C1-L5C19).According to
git bisect
, this is the culprit: 0a76199 (released in Sphinx 7.3.0).Environment Information
Sphinx extensions
['sphinxcontrib.rsvgconverter']
Additional context
See #10073 and #10118, which might be related.
The text was updated successfully, but these errors were encountered: