Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntlm: RDoc is not a full Ruby parser and will fail when fed invalid ruby programs: undefined method `[]' for nil:NilClass #25

Open
marccarre opened this issue Apr 9, 2020 · 2 comments

Comments

@marccarre
Copy link

First and foremost, many thanks for this library! 馃檱 馃憤
FYI and in case something can be done about it, I got an error related to ntlm's documentation during installation:

$ gem install kindle-highlights
Fetching unf_ext-0.0.7.7.gem
Fetching unf-0.1.4.gem
Fetching domain_name-0.5.20190701.gem
Fetching webrobots-0.1.2.gem
Fetching net-http-persistent-3.1.0.gem
Fetching ntlm-http-0.1.1.gem
Fetching http-cookie-1.0.3.gem
Fetching connection_pool-2.2.2.gem
Fetching kindle-highlights-2.0.1.gem
Fetching mime-types-data-3.2019.1009.gem
Fetching mime-types-3.3.1.gem
Fetching net-http-digest_auth-1.4.1.gem
Fetching mechanize-2.7.6.gem
Building native extensions. This could take a while...
Successfully installed unf_ext-0.0.7.7
Successfully installed unf-0.1.4
Successfully installed domain_name-0.5.20190701
Successfully installed webrobots-0.1.2
Successfully installed ntlm-http-0.1.1
Successfully installed http-cookie-1.0.3
Successfully installed connection_pool-2.2.2
Successfully installed net-http-persistent-3.1.0
Successfully installed mime-types-data-3.2019.1009
Successfully installed mime-types-3.3.1
Successfully installed net-http-digest_auth-1.4.1
Successfully installed mechanize-2.7.6
Successfully installed kindle-highlights-2.0.1
Parsing documentation for unf_ext-0.0.7.7
Installing ri documentation for unf_ext-0.0.7.7
Parsing documentation for unf-0.1.4
Installing ri documentation for unf-0.1.4
Parsing documentation for domain_name-0.5.20190701
Installing ri documentation for domain_name-0.5.20190701
Parsing documentation for webrobots-0.1.2
Installing ri documentation for webrobots-0.1.2
Parsing documentation for ntlm-http-0.1.1
Before reporting this, could you check that the file you're documenting
has proper syntax:

  ${HOME}/.rbenv/versions/2.6.3/bin/ruby -c lib/net/ntlm.rb

RDoc is not a full Ruby parser and will fail when fed invalid ruby programs.

The internal error was:

	(NoMethodError) undefined method `[]' for nil:NilClass

ERROR:  While executing gem ... (NoMethodError)
    undefined method `[]' for nil:NilClass

$ which ruby
${HOME}/.rbenv/shims/ruby

$ ruby -v
ruby 2.6.3p62 (2019-04-16 revision 67580) [x86_64-darwin19]

$ gem env
RubyGems Environment:
  - RUBYGEMS VERSION: 3.0.3
  - RUBY VERSION: 2.6.3 (2019-04-16 patchlevel 62) [x86_64-darwin19]
  - INSTALLATION DIRECTORY: ${HOME}/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0
  - USER INSTALLATION DIRECTORY: ${HOME}/.gem/ruby/2.6.0
  - RUBY EXECUTABLE: ${HOME}/.rbenv/versions/2.6.3/bin/ruby
  - GIT EXECUTABLE: /usr/local/bin/git
  - EXECUTABLE DIRECTORY: ${HOME}/.rbenv/versions/2.6.3/bin
  - SPEC CACHE DIRECTORY: ${HOME}/.gem/specs
  - SYSTEM CONFIGURATION DIRECTORY: ${HOME}/.rbenv/versions/2.6.3/etc
  - RUBYGEMS PLATFORMS:
    - ruby
    - x86_64-darwin-19
  - GEM PATHS:
     - ${HOME}/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0
     - ${HOME}/.gem/ruby/2.6.0
  - GEM CONFIGURATION:
     - :update_sources => true
     - :verbose => true
     - :backtrace => false
     - :bulk_threshold => 1000
  - REMOTE SOURCES:
     - https://rubygems.org/
  - SHELL PATH:
     - ${HOME}/.rbenv/versions/2.6.3/bin
     - /usr/local/Cellar/rbenv/1.1.2/libexec
     - ${HOME}/.gem/ruby/2.6.0/bin
     - ${HOME}/.rbenv/shims
     - /usr/local/bin
     - /usr/local/sbin
     - ${HOME}/bin
     - /usr/bin
     - /bin
     - /usr/sbin
     - /sbin
     # <redacted>

It didn't seem to prevent from importing the library though:

$ irb
irb(main):001:0> require 'kindle_highlights'
=> true
@Linell
Copy link

Linell commented Apr 16, 2020

I'm experiencing this issue as well 馃憤

@speric
Copy link
Owner

speric commented Apr 17, 2020

There are some issues with the current implementation because Amazon has changed the structure of their login page. I am working on a fix but don't have an ETA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants