Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jss_article() used in vignettes requires Pandoc 2.7 with newer rticles version #219

Open
cderv opened this issue Dec 20, 2023 · 1 comment
Assignees

Comments

@cderv
Copy link

cderv commented Dec 20, 2023

Hi,

while preparing new release of rticles I found out that you were using jss_article() for vignettes.

Just a heads up that due to possible change in jss.cls, we needed to update the requirement of jss_article() to Pandoc 2.7+ (released 4 years ago on 2019-03-03)

So on system with pandoc < 2.7, building the vignette in your package will error.

Not sure this is a problem for CRAN release, if they to keep their Pandoc updated.

You may want to change your pandoc version test to 2.7 instead of 2.2 to be safe

output: if (rmarkdown::pandoc_version() < "2.2") function(...) { rmarkdown::pdf_document(template = "./template.tex", ...) } else function(...) { bookdown::pdf_book(base_format = rticles::jss_article, ...) }

output: if (rmarkdown::pandoc_version() < "2.2") function(...) { rmarkdown::pdf_document(template = "./template.tex", ...) } else function(...) { bookdown::pdf_book(base_format = rticles::jss_article, ...) }

@cderv cderv changed the title jss_article() uses in vignettes requires Pandoc 2.7 with newer rticles version jss_article() used in vignettes requires Pandoc 2.7 with newer rticles version Dec 20, 2023
@spedygiorgio spedygiorgio self-assigned this Dec 26, 2023
@spedygiorgio
Copy link
Owner

spedygiorgio commented Dec 26, 2023

Thank you @cderv for your suggestions. I will handle it in the forthcoming package version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants