Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove System.Memory dependency from net 6+ #1519

Closed
thompson-tomo opened this issue Apr 16, 2024 · 4 comments
Closed

Remove System.Memory dependency from net 6+ #1519

thompson-tomo opened this issue Apr 16, 2024 · 4 comments

Comments

@thompson-tomo
Copy link

Is your feature request related to a problem? Please describe.
I want to minimise dependencies in my project by utilising framework dependencies wherever possible

Describe the solution you'd like
I want the package to not have an explicit dependency on System.Memory on net 6+.

Describe alternatives you've considered
Accept the additional dependency

Additional context
n/


Please upvote 👍 this issue if you are interested in it.

@patriksvensson
Copy link
Contributor

@thompson-tomo Spectre.Console does not have a dependency on System.Memory on net6.0. It has a conditional dependency on that package for netstandard2.0.

CleanShot 2024-04-17 at 01 29 58@2x

@thompson-tomo
Copy link
Author

thompson-tomo commented Apr 17, 2024

Ahh, I had not checked the preview packages and only looked at the release versions.

@patriksvensson
Copy link
Contributor

patriksvensson commented Apr 17, 2024

Hmm, we might actually need to investigate this. Seems like packaging doesn't respect the target framework condition for some reason: https://www.nuget.org/packages/Spectre.Console/

CleanShot 2024-04-17 at 09 51 58@2x

@patriksvensson patriksvensson self-assigned this Apr 17, 2024
@thompson-tomo
Copy link
Author

Closing this as it is now not being included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 🚀
Development

No branches or pull requests

2 participants