New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panel in layout adds newline in more complex layout split #1390
Comments
@patrickfreilinger It looks like this issue is related to how the Ratio is calculated. Essentially the calculation in this loop will have a remainder very close to one (for example .99999) but the
For example in the case of a height of 17, the 3 sections are of height [5,6,5] adding up to 16 while the right side is of length 17. A possible fix is to add a check into the
After this change the sizes are [5, 6, 6] and there is no longer an issue with the 2 halves being of different heights. |
Information
Describe the bug
There's some issue with adding newline or setting the wrong height on panel. It occurs mostly when there are 3 rows in layout and height of AnsiConsole is a specific number e.g. 17, 20, 23, 28, 31. Changing console height to other "correct" number seems to resolve the problem, so I would assume it's correlated to some measurement calculation?
To Reproduce
Run this code and set height of terminal to specific number e.g. provided above or try to change height by one unit at a time, until issue occurs.
Expected behavior
Display correct panels, without newline.
Screenshots
Should be:
but is:
Please upvote 👍 this issue if you are interested in it.
The text was updated successfully, but these errors were encountered: