HelpProvider colors

[sebbarg]

The colors in the HelpProvider are hardcoded. Showing help on a bright background (e.g. old school default MacOS terminal) becomes really hard to read, primarily because of the yellow colors.

How do I deal with that? I can create a custom help provider, but that seems a bit much just to fix some hardcoded colors.

[FrankRay78]

Probably a valid case for localising the colours, like what we've just done with the help text. Or maybe having them as config parameters on the help writer, or similar. Agree you shouldn't have to re-implement the entire help writer just for this. Plus hardcoded colours is bad for accessibility.

[FrankRay78]

I've created an issue for this: #1379

[FrankRay78]

Check out this branch if you get a chance @sebbarg : #1408

[sebbarg]

Awesome!