You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a conflict between this and Spatie's sluggable package, due to the fact that the Tag model has a trait called 'HasSlugs' on it, which is the same as the one from the sluggable package.
As the sluggable package has mechanics for translatable slugs already supported, would it make sense to replace the local slug mechanics with those from that package?
I'd happily try and put together a PR for it, if it were going to me considered. It would be a breaking change, but would solve the conflict between the two.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
There is a conflict between this and Spatie's sluggable package, due to the fact that the Tag model has a trait called 'HasSlugs' on it, which is the same as the one from the sluggable package.
As the sluggable package has mechanics for translatable slugs already supported, would it make sense to replace the local slug mechanics with those from that package?
I'd happily try and put together a PR for it, if it were going to me considered. It would be a breaking change, but would solve the conflict between the two.
Beta Was this translation helpful? Give feedback.
All reactions