-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kSecAttrProtocol meaningless on generic password #1448
Comments
macOS doesn't support EdDSA keys "natively" as key storage, so I've had to shove it into a password, and make it seem as much like a key as possible. I couldn't find good docs about meaning and applicability of all these properties, so it's likely that not all of them are needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Setting (or querying) the kSecAttrProtocol property of a generic password is not meaningful, AFAICT.
AFAICT it is only meaningful for an Internet password, which Sparkle does not use.
Therefore, the 3 instances of setting or querying for kSecAttrProtocol with value kSecAttrProtocolSSH don't seem to be wrong, per se, but sure are misleading!
https://github.com/sparkle-project/Sparkle/search?q=kSecAttrProtocol&unscoped_q=kSecAttrProtocol
The text was updated successfully, but these errors were encountered: