-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chapter 1.1.7: Exercise 1.7 #958
Comments
OK. Thanks. Can you make an issue in the repo on this please.
…On Thu, 14 Dec 2023, 21:47 Kenny Chow, ***@***.***> wrote:
Simply adjusting/scaleing the tolerance with x will do, instead of
complicating the logic with the current solution.
Consider:
function is_good_enough(guess, x) {
return abs(square(guess) - x) < x * 0.001;
}
Instead of:
const error_threshold = 0.01;
function is_good_enough(guess, x) {
return relative_error(guess, improve(guess, x))
< error_threshold;
}
function relative_error(estimate, reference) {
return abs(estimate - reference) / reference;
}
Defining the error_threshold outside is a good practice.
So maybe also consider:
const error_threshold = 0.001;
function is_good_enough(guess, x) {
return abs(square(guess) - x) < x * error_threshold;
}
—
Reply to this email directly, view it on GitHub
<#958>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHGSDYDS6ZLOVVD32GQF73DYJMGQRAVCNFSM6AAAAABAU7AFPCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2DCOBVGQ4TCMQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Simply adjusting/scaling the tolerance with x will do, instead of complicating the logic with the current solution.
Consider:
Instead of:
Defining the error_threshold outside is a good practice.
So maybe also consider:
Relatively minor: keeping the original threshold = 0.001 instead of changing it to 0.01.
The text was updated successfully, but these errors were encountered: