EDNS Client Subnet (ECS) does not work with resolve

[I-Knight-I]

EDNS Client Subnet support does not work because the call to resolve in query is malformed.

query

node-dns/index.js

Line 46 in b2fdf66

return resolve(name, type, cls, clientIp);

resolve

node-dns/client/udp.js

Line 9 in b2fdf66

return (name, type = 'A', cls = Packet.CLASS.IN, { clientIp, recursive = true } = {}) => {

The fixed call should be:

return resolve(name, type, cls, { clientIp, recursive });

However

I cannot get ECS to work even after this change. Entering the same CDN domain but with one clientIp in Europe and another in the USA, I get the same resolved IP address. This is with both Google's DNS (8.8.8.8) as well as Quad9's ECS-enabled DNS (9.9.9.11).

If I use Resolve-DnsName or dig then the same CDN domain's resolved IP changes depending on the provided subnet / source IP address.

The above is why I've opted to raise an issue and not a PR, as I do not know how to fix the underlying ECS support.