Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make configuration directory configurable #109

Merged
merged 5 commits into from
May 29, 2024

Conversation

sam57719
Copy link
Collaborator

No description provided.

This commit adds support for handling external configuration and log files. It modifies the configuration, Dockerfile, setup, and README to establish the paths and volumes for these files. It also enhances the logging setup to handle potential issues when loading configuration from an external JSON file.
The Dockerfile has been revised to better handle the logging.json file. It now removes the original logging.json file from the smib directory, and then repositions it to the appropriate container location, preventing potential issues when loading configuration data from an external source.
@sam57719 sam57719 linked an issue May 20, 2024 that may be closed by this pull request
README.md Outdated Show resolved Hide resolved
network ports heading
Copy link
Member

@sjefferson99 sjefferson99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sam57719 Will test following the linux mount and local dev config location override and make sure docs work and make sense this evening.

Copy link
Member

@sjefferson99 sjefferson99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sjefferson99 sjefferson99 merged commit cb57352 into develop May 29, 2024
@sjefferson99 sjefferson99 deleted the 30-make-configuration-directory-configurable branch May 29, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make configuration directory configurable
2 participants